Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper
From: Luke Howard
Date: Thu May 28 2026 - 06:16:03 EST
> On 28 May 2026, at 6:11 pm, Cedric Jehasse <cedric.jehasse@xxxxxxxxx> wrote:
>
> On Thu, May 28, 2026 at 2:17 AM Luke Howard <lukeh@xxxxxxxx> wrote:
>
>> This actually makes more sense also now that you pointed out that AVB mode is set on the ingress, not egress, port: configuring CBS should stay out of setting any of the AVB mode bits. Are you planning to submit a MQPRIO patch? If not, shall I just wait for your CBS patch to land, and then rebase my AVB patch series on top of net-next?
>
> No, I don't have changes to support MQPRIO in the driver. I use the
> default FPri/Qpri mappings at the moment.
This is a salient point: in my MQPRIO patch series, offloaded TCs 2 and 1 represent AVB classes (with 0 representing non-AVB traffic). This is the most natural mapping to take advantage of the switches’ native AVB support.
But there’s an alternate mapping where TCs represent switch queues and can be used to configure arbitrary FPri/QPri mappings.
It would be good to support both, particularly for switches with >4 queues. Maybe this can be keyed the presence of the DT property (now renamed, marvell,avb-mode).