Re: [PATCH net v3 1/1] net/sched: fix pedit partial COW leading to page cache corruption
From: David Laight
Date: Thu May 28 2026 - 07:31:54 EST
On Thu, 28 May 2026 12:03:04 +0200
Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote:
...
> > 2) Add more optimal boundary checks (Toke & David L.)
>
> [..]
>
> > - if (offset < 0 && -offset > skb_headroom(skb))
> > + if (offset < 0 && offset < -(int)skb_headroom(skb))
>
...
>
> However, I don't think this matters, this version is not actually buggy;
> so let's just get this merged, and we can code-golf the offset check on
> top :)
I prefer it in pink :-)