Re: [RFC PATCH 03/10] rcu/segcblist: Change gp_seq to struct rcu_gp_oldstate gp_seq_full

[Frederic Weisbecker]

Hi,

Le Fri, Apr 17, 2026 at 04:11:51PM -0700, Puranjay Mohan a écrit :
> @@ -496,7 +496,7 @@ static void rcu_segcblist_advance_compact(struct rcu_segcblist *rsclp, int i)
>   * Advance the callbacks in the specified rcu_segcblist structure based
>   * on the current value passed in for the grace-period counter.
>   */
> -void rcu_segcblist_advance(struct rcu_segcblist *rsclp, unsigned long seq)
> +void rcu_segcblist_advance(struct rcu_segcblist *rsclp, struct rcu_gp_oldstate *rgosp)

If the name struct rcu_gp_oldstate makes sense when it refers to grace period
sequence numbers waited upon by a given segment, it becomes confusing when
passed here as the current grace period number to compare against waited upon
snapshots.

So how about struct rcu_gp_seq for everyone instead?

Thanks.

-- 
Frederic Weisbecker
SUSE Labs