Re: [PATCH v2 5/5] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra
From: Dmitry Baryshkov
Date: Thu May 28 2026 - 09:46:38 EST
On Thu, May 28, 2026 at 03:37:06PM +0530, Imran Shaik wrote:
> The Qualcomm Shikra GPU clock controller is similar to QCM2290 GPUCC
> hardware block, with minor differences. Drop modelling of critical
> clocks and keep them enabled at probe time, update the QCM2290 GPUCC
> driver to align with the latest common qcom_cc_probe() model. Update the
> GDSC *_wait_val and flags which are applicable for both QCM2290 and Shikra.
There are a lot of separate, unrelated changes. Split your patches (not
only this one) following the 'atomic logical changes' approach.
> Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> ---
> drivers/clk/qcom/gpucc-qcm2290.c | 174 +++++++++++++++++----------------------
> 1 file changed, 74 insertions(+), 100 deletions(-)
>
--
With best wishes
Dmitry