Re: [PATCH] net: qrtr: fix node refcount leak on ctrl packet alloc failure
From: Alexander Lobakin
Date: Thu May 28 2026 - 10:39:32 EST
From: Wentao Liang <vulab@xxxxxxxxxxx>
Date: Thu, 28 May 2026 08:00:19 +0000
> [PATCH] net: qrtr: fix node refcount leak on ctrl packet alloc failure
Please specify the net tree in the subject prefix, i.e. [PATCH net].
> qrtr_send_resume_tx() calls qrtr_node_lookup() which takes a
> reference on the returned node. If the subsequent call to
> qrtr_alloc_ctrl_packet() fails due to memory allocation failure, the
> function returns -ENOMEM without calling qrtr_node_release() to
> release the node reference.
>
> Add qrtr_node_release(node) before returning on the allocation failure
> path to properly release the reference.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: cb6530b99faf ("net: qrtr: Move resume-tx transmission to recvmsg")
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
Thanks,
Olek