RE: [PATCH net] net: lan743x: avoid netdev-based logging before netdev registration

[David Thompson]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Wednesday, May 27, 2026 5:56 PM
> To: David Thompson <davthompson@xxxxxxxxxx>
> Cc: bryan.whitehead@xxxxxxxxxxxxx; UNGLinuxDriver@xxxxxxxxxxxxx;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] net: lan743x: avoid netdev-based logging before
> netdev registration
> 
> On Wed, 27 May 2026 17:27:13 +0000 David Thompson wrote:
> > While preparing v2, I realized it makes more sense to add a module
> > parameter to control the initial value of msg_enable, instead of
> > hardcoding it during probe. I'll update v2 to include this change,
> > which means I'll also need to keep the checks that were previously
> > always true.
> 
> Sigh, no. Please don't perpetuate this stupid log categorization.
> The module param is not present, that means nobody needs it.
> 
> Also when you repost please target net-next and drop the Fixes tag.
> I don't think it will make the cut as a fix given Linus's message from -rc5
> announcement.

Thanks for the reply Jakub.

I will remove patch #1 (which adds the module parameter) from the patch series,
update logic in patch #2 accordingly and create a v3 for net-next.  

- Dave