Re: [PATCH v2] gpu: host1x: fix missing 'host1x_context_device_bus_type'
From: Thierry Reding
Date: Thu May 28 2026 - 11:06:01 EST
On Fri, Jan 23, 2026 at 02:05:12PM +0000, Ben Dooks wrote:
> The drivers/gpu/host1x/context_bus.c does not include
> any declaration of host1x_context_device_bus_type, and
> after including "context.h" it also showed that there
> are two definitons in the kernel, so fix those two
>
> Fix by removing the definition in context.h and include
> <linux/host1x_context_bus.h> in context_bus.c
>
> Fixes the following sparse warning:
> drivers/gpu/host1x/context_bus.c:9:23: warning: symbol 'host1x_context_device_bus_type' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> --
> v2:
> - removed fixes line
> - changed to include into the c files directly
> ---
> drivers/gpu/host1x/context.c | 1 +
> drivers/gpu/host1x/context.h | 2 --
> drivers/gpu/host1x/context_bus.c | 1 +
> 3 files changed, 2 insertions(+), 2 deletions(-)
Applied this with Mikko's comments worked in. I also updated the commit
message a tiny bit and added a predeclaration of struct
host1x_memory_context in context.h out of an extra abundance of caution.
Thierry
Attachment:
signature.asc
Description: PGP signature