Re: [PATCH] ASoC: sprd: sprd-mcdt: Use guard() for mutex & spin locks
From: Mark Brown
Date: Thu May 28 2026 - 12:55:34 EST
On Thu, May 28, 2026 at 05:59:00PM +0700, phucduc.bui@xxxxxxxxx wrote:
> @@ -897,7 +869,7 @@ void sprd_mcdt_free_chan(struct sprd_mcdt_chan *chan)
> sprd_mcdt_chan_dma_disable(chan);
> sprd_mcdt_chan_int_disable(chan);
>
> - mutex_lock(&sprd_mcdt_list_mutex);
> + guard(mutex)(&sprd_mcdt_list_mutex);
>
> list_for_each_entry(temp, &sprd_mcdt_chan_list, list) {
> if (temp == chan) {
> @@ -907,7 +879,6 @@ void sprd_mcdt_free_chan(struct sprd_mcdt_chan *chan)
> }
>
> list_add_tail(&chan->list, &sprd_mcdt_chan_list);
> - mutex_unlock(&sprd_mcdt_list_mutex);
> }
> EXPORT_SYMBOL_GPL(sprd_mcdt_free_chan);
There's a mutex_unlock() in that temp == chan case there.
Attachment:
signature.asc
Description: PGP signature