Re: [PATCH] rust: module_param: add missing newline to pr_warn

[Sami Tolvanen]

On Thu, May 28, 2026 at 1:56 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Thu, May 21, 2026 at 6:14 PM Kenny Glowner
> <sisyphuscode0311@xxxxxxxxx> wrote:
> >
> > Add a trailing newline ('\n') to the pr_warn! call in set_param to
> > ensure the kernel ring buffer flushes the message correctly and
> > prevents log line smearing.
>
> Did you see log smearing? IIRC this changed with the buffer rework --
> it is still the convention we expect, though, so the diff contents are
> good.
>
> > Link: https://github.com/Rust-for-Linux/linux/issues/1139
> >
> > Signed-off-by: Kenny Glowner <SisyphusCode0311@xxxxxxxxx>
>
> Andreas, Sami, Daniel, Luis, Petr: will this one go through modules
> too? Otherwise, please let me know and I can take it.

Yes, I'll take this one through modules too. Thanks, Miguel.

Sami