Re: [PATCH v3 06/16] KVM: selftests: Add IRQ injection test
From: Sean Christopherson
Date: Thu May 28 2026 - 19:14:24 EST
+lists and cc (I assume you accidentally replied only to me)
On Thu, May 28, 2026, Josh Hilke wrote:
> On Tue, May 26, 2026 at 6:59 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> >
> > On Tue, Apr 21, 2026, Josh Hilke wrote:
> > > From: David Matlack <dmatlack@xxxxxxxxxx>
> > >
> > > Add a new test, irq_test.c, which verifies that KVM correctly injects
> > > interrupts into a running guest when triggered via an eventfd bound to a
> > > GSI using the irqfd mechanism.
> >
> > Can you add some color explaining that this will/should work with IRQ bypass?
> > I assume it does right out of the gate.
>
> I think that explanation should go into patch 7 where we add support
> for routing interrupts from a real device:
> "KVM: selftests: Verify device IRQs are routed to vCPUs"
Yeah, I belatedly remembered that the test initially only supported injection.
Can you expand the changelog to call out that the initial commit is intentionally
"barebones", and that support for things like real devices/VFs and IRQ bypass will
be added in the future? Doesn't have to be much, just something to clue in the
reader that they aren't missing anything.