Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper

[Luke Howard]

> On 28 May 2026, at 10:46 pm, Andrew Lunn <andrew@xxxxxxx> wrote:
> 
>> It would be good to support both, particularly for switches with >4
>> queues. Maybe this can be keyed the presence of the DT property (now
>> renamed, marvell,avb-mode).
> 
> You need to be careful with DT. It represents hardware. Configuration
> of that hardware, or policy, should not be in DT.

Noted. The tradeoff is I don’t user space to be aware of specific hardware, i.e. a SRP daemon should not care whether it is using HW offload or a software bridge. But it would also be ideal to allow a 1:1 mapping of TCs to queues non-AVB uses such as Cedric’s.

A similarly sized hammer to DT would be a command-line option. Another option that requires a small user space change would be to add (say) TC_MQPRIO_MODE_CHANNEL_SRP, or to overload TC_MQPRIO_MODE_DCB for AVB.

Thoughts?

Luke