Re: [PATCH 3/6] rust: drm: Add RegistrationData to drm::Driver

From: lyude

Date: Thu May 28 2026 - 21:02:20 EST


On Thu, 2026-05-28 at 20:15 -0400, lyude@xxxxxxxxxx wrote:
> FWIW: now that I've noticed this, that might simplify things w/r/t
> what
> KMS needs here from DeviceContext and allow me to go from modeling
> DeviceContext around 3 stages (Uninit, Initialized, Registered), to
> just 2 stages (Initialized, Registered). The purpose of having a
> separate Uninit and Initialized had been to workaround not having
> access to `drm::Driver::Data` when a driver performs an atomic commit
> before userspace registration, which would be a big ergonomic issue
> for
> implementing a lot of atomic KMS callbacks.
>
> But if that's not an issue with this patch series, then it probably
> makes more sense for me to respin that DeviceContext patch series to
> reflect that since that simplifies things a lot for the KMS side. For
> your patch series, it just means you have to replace "Uninit" with
> "Initialized" in the next version.
>
> I will send out a respin with this tomorrow after working on
> respinning
> the gem shmem patch series, since that shouldn't take me very long at
> all.

Actually - after working on it a little bit more, I think having the 3
states (Uninit, Initialized, Registered) is still going to make sense
for KMS. So, I probably actually don't need to respin/change the
DeviceContext series from how it is right now after all! Sorry for the
noise :)