Re: [PATCH 2/2] selftests/damon: validate memcg filter sysfs readback
From: Cheng Nie
Date: Thu May 28 2026 - 23:33:16 EST
On Thu, 28 May 2026 07:28:18 -0700 SeongJae Park wrote:
> Could we use 'selftests/damn/sysfs.py:' as the prefix of the subject?
> That will make it consistent with other commits and let us easily know
> to what test this change is made.
Will do in v2.
> But this is in the middle of assert_filter_committed(). As the name
> says, this is for validating if the user inputs are passed to DAMON
> internal. I think this is not the right place to test its 'staging'
> functionality.
Will do. I will remove the memcg_path readback check from
assert_filter_committed() in v2.
> What about adding another test case at the end of the main() function
> for the validation of memcg string staging functionality?
Will do. I will add a dedicated test case at the end of main() in v2.
Thanks,
Cheng Nie