Re: [PATCH v4 08/10] fs/resctrl: Change last_cmd_status custom during input parsing

[Reinette Chatre]

Hi Tony,

On 5/28/26 4:38 PM, Luck, Tony wrote:
> On Wed, Apr 29, 2026 at 08:06:38AM -0700, Reinette Chatre wrote:

>> @@ -324,6 +319,15 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of,
>>  	}
>>  	rdt_last_cmd_clear();
>>  
>> +	/* Valid input requires a trailing newline */
>> +	if (nbytes == 0 || buf[nbytes - 1] != '\n') {
>> +		rdt_last_cmd_puts("Invalid input\n");
> 
> This is obviously a big improvement over existing failure to provide a
> message (or leaving previous stale message). Do you want to go the extra
> mile and disambiguate all these "Invalid input" messages?  E.g. here:
> 
> 		rdt_last_cmd_puts("schemata: Invalid input\n");
> 
> It's good to have a grep-able pattern to diagnostics.

Good point. Will do.

> 
> All the other patches in this series look great. You can add my
> 
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>

Thank you very much for taking a look.

Reinette