Re: [PATCH -next] firmware: imx: se_ctrl: serialize command receiver registration

[kernel test robot]

Hi Pankaj,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20260527]

url:    https://github.com/intel-lab-lkp/linux/commits/Pankaj-Gupta/firmware-imx-se_ctrl-serialize-command-receiver-registration/20260528-172942
base:   next-20260527
patch link:    https://lore.kernel.org/r/20260528091634.3331090-1-pankaj.gupta%40nxp.com
patch subject: [PATCH -next] firmware: imx: se_ctrl: serialize command receiver registration
config: s390-randconfig-r121-20260529 (https://download.01.org/0day-ci/archive/20260529/202605291211.iAxyywQe-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 8.5.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260529/202605291211.iAxyywQe-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605291211.iAxyywQe-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/firmware/imx/se_ctrl.c: In function 'se_ioctl':
>> drivers/firmware/imx/se_ctrl.c:933:1: error: label at end of compound statement
    out_enable_cmd_rcv:
    ^~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MFD_STMFX
   Depends on [n]: HAS_IOMEM [=y] && I2C [=y] && OF [=n]
   Selected by [m]:
   - PINCTRL_STMFX [=m] && PINCTRL [=y] && I2C [=y] && HAS_IOMEM [=y]


vim +933 drivers/firmware/imx/se_ctrl.c

   905	
   906	/* IOCTL entry point of a character device */
   907	static long se_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
   908	{
   909		struct se_if_device_ctx *dev_ctx = fp->private_data;
   910		struct se_if_priv *priv = dev_ctx->priv;
   911		void __user *uarg = (void __user *)arg;
   912		long err;
   913	
   914		/* Prevent race during change of device context */
   915		scoped_cond_guard(mutex_intr, return -EBUSY, &dev_ctx->fops_lock) {
   916			switch (cmd) {
   917			case SE_IOCTL_ENABLE_CMD_RCV:
   918				scoped_guard(mutex, &priv->priv_dev_ctx->fops_lock) {
   919					if (priv->cmd_receiver_clbk_hdl.dev_ctx) {
   920						err = -EBUSY;
   921						goto out_enable_cmd_rcv;
   922					}
   923					priv->cmd_receiver_clbk_hdl.rx_msg =
   924									kzalloc(MAX_NVM_MSG_LEN,
   925										GFP_KERNEL);
   926					if (!priv->cmd_receiver_clbk_hdl.rx_msg) {
   927						err = -ENOMEM;
   928						goto out_enable_cmd_rcv;
   929					}
   930					priv->cmd_receiver_clbk_hdl.rx_msg_sz = MAX_NVM_MSG_LEN;
   931					priv->cmd_receiver_clbk_hdl.dev_ctx = dev_ctx;
   932					err = 0;
 > 933	out_enable_cmd_rcv:
   934				}
   935				break;
   936			case SE_IOCTL_GET_MU_INFO:
   937				err = se_ioctl_get_mu_info(dev_ctx, uarg);
   938				break;
   939			case SE_IOCTL_SETUP_IOBUF:
   940				err = se_ioctl_setup_iobuf_handler(dev_ctx, uarg);
   941				break;
   942			case SE_IOCTL_GET_SOC_INFO:
   943				err = se_ioctl_get_se_soc_info_handler(dev_ctx, uarg);
   944				break;
   945			case SE_IOCTL_CMD_SEND_RCV_RSP:
   946				err = se_ioctl_cmd_snd_rcv_rsp_handler(dev_ctx, uarg);
   947				break;
   948			default:
   949				err = -EINVAL;
   950				dev_dbg(priv->dev, "%s: IOCTL %.8x not supported.",
   951					dev_ctx->devname, cmd);
   952			}
   953		}
   954	
   955		return err;
   956	}
   957	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki