Re: [PATCH v1 1/2] hwmon: cros_ec: Drop unused assignment of platform_device_id driver data

From: Thomas Weißschuh

Date: Fri May 29 2026 - 01:38:15 EST


On 2026-05-27 17:15:52+0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignments.
>
> While touching this array unify spacing and

> use named initializers for .name.

Not sure why this is better.

> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

... but it doesn't really matter, so:
Acked-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

> ---
> drivers/hwmon/cros_ec_hwmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c
> index 7c308b0a4b9e..f6cf254395a8 100644
> --- a/drivers/hwmon/cros_ec_hwmon.c
> +++ b/drivers/hwmon/cros_ec_hwmon.c
> @@ -654,8 +654,8 @@ static int cros_ec_hwmon_resume(struct platform_device *pdev)
> }
>
> static const struct platform_device_id cros_ec_hwmon_id[] = {
> - { DRV_NAME, 0 },
> - {}
> + { .name = DRV_NAME },
> + { }
> };
> MODULE_DEVICE_TABLE(platform, cros_ec_hwmon_id);
>
> --
> 2.47.3
>