Re: [PATCH v8 2/2] Input: Add support for Wacom W9000-series penabled touchscreens

[Dmitry Torokhov]

Hi Hendrik,

On Thu, May 28, 2026 at 09:48:18AM +0200, Hendrik Noack wrote:
> +
> +struct wacom_w9000_data {
> +	struct i2c_client *client;
> +	struct input_dev *input_dev;
> +	const struct wacom_w9000_variant *variant;
> +	u16 fw_version;
> +
> +	struct touchscreen_properties prop;
> +	u16 max_pressure;
> +
> +	struct regulator *regulator;
> +	bool powered;

We do not really need this flag as ling as you use
input_device_enabled() in wacom_w9000_suspend().

...

> +
> +	dev_dbg(dev, "max_x:%d, max_y:%d, max_pressure:%d, fw:%#x", wacom_data->prop.max_x,
> +		wacom_data->prop.max_y, wacom_data->max_pressure,
> +		wacom_data->fw_version);

Here and in couple of other places we miss '\n' in the diagnostic
messages.

> +
> +	input_dev->name = wacom_data->variant->name;
> +	input_dev->id.bustype = BUS_I2C;
> +	input_dev->dev.parent = dev;

This is not needed: devm_input_allocate_device() sets the patent for us.

No need to resubmit, I made edits on my end.

Thanks.

-- 
Dmitry