Re: [PATCH 16/16] arm64: dts: qcom: shikra: enable WiFi on EVK boards

[Miaoqing Pan]

On 5/25/2026 5:34 PM, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 01:19:20AM +0530, Komal Bajaj wrote:
> > From: Miaoqing Pan <miaoqing.pan@xxxxxxxxxxxxxxxx>
> >
> > Enable WiFi support on Shikra CQS, CQM and IQS EVK variants.
> >
> > Provide board-specific WiFi configuration, including power supply
> > connections and calibration variant selection. The WiFi node is
> > enabled on each EVK according to the corresponding PMIC and board
> > design.
> >
> > Signed-off-by: Miaoqing Pan <miaoqing.pan@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 11 +++++++++++
> >   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 11 +++++++++++
> >   arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 19 +++++++++++++++++++
> It makes me wonder... You've added DSPs in three patches, one per board,
> but BT and WiFi go together. Where is the logiic?
>
> >   3 files changed, 41 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> > index 259032bd20af..15208e1abff6 100644
> > --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> > @@ -69,3 +69,14 @@ bluetooth {
> >   		vddch0-supply = <&pm4125_l22>;
> >   	};
> >   };
> > +
> > +&wifi {
> > +	vdd-0.8-cx-mx-supply = <&pm4125_l7>;
> > +	vdd-1.8-xo-supply = <&pm4125_l13>;
> > +	vdd-1.3-rfa-supply = <&pm4125_l10>;
> > +	vdd-3.3-ch0-supply = <&pm4125_l22>;
> Squash with the BT changes. Use the PMU-based bindings. Don't forget the
> swctrl GPIO.
WCN3990 does not rely on the PMU module; it is managed directly by 
ath10k, so the swctrl GPIO is not needed. The details are described in 
qcom,ath10k.yaml.


> > +	qcom,calibration-variant = "Shikra_EVK";
> Was this submitted to ath10k-firmware?
Not yet.

> > +	firmware-name = "cq2390";
> > +
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > index 142cc8da53ce..51267c1a86b3 100644
> > --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> > @@ -69,3 +69,14 @@ bluetooth {
> >   		vddch0-supply = <&pm4125_l22>;
> >   	};
> >   };
> > +
> > +&wifi {
> > +	vdd-0.8-cx-mx-supply = <&pm4125_l7>;
> > +	vdd-1.8-xo-supply = <&pm4125_l13>;
> > +	vdd-1.3-rfa-supply = <&pm4125_l10>;
> > +	vdd-3.3-ch0-supply = <&pm4125_l22>;
> > +	qcom,calibration-variant = "Shikra_EVK";
> > +	firmware-name = "cq2390";
> > +
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> > index 9bf52030bcc5..f4e93cfb77e3 100644
> > --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> > @@ -30,6 +30,14 @@ vreg_bt_3p3_dummy: regulator-bt-3p3-dummy {
> >   		regulator-max-microvolt = <3300000>;
> >   		regulator-always-on;
> >   	};
> > +
> > +	vreg_wlan_3p3_dummy: regulator-wlan-3p3-dummy {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "wlan_3p3_dummy";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-always-on;
> Why is it dummy? Is there no regulator on the board?

WCN3950_3P3_CHAIN0 :is powered by on Board 3rd Party Buck which is always ON, VREG_SYS is always on once the device is powered up.

> > +	};
> >   };
> >   
> >   &remoteproc_cdsp {
> > @@ -77,3 +85,14 @@ bluetooth {
> >   		vddch0-supply = <&vreg_bt_3p3_dummy>;
> >   	};
> >   };
> > +
> > +&wifi {
> > +	vdd-0.8-cx-mx-supply = <&pm8150_s4>;
> > +	vdd-1.8-xo-supply = <&pm8150_l12>;
> > +	vdd-1.3-rfa-supply = <&pm8150_l8>;
> > +	vdd-3.3-ch0-supply = <&vreg_wlan_3p3_dummy>;
> > +	qcom,calibration-variant = "Shikra_EVK";
> > +	firmware-name = "cq2390";
> > +
> > +	status = "okay";
> > +};
> >
> > --
> > 2.34.1