Re: [PATCH net-next v2 3/3] net: macb: add TX stall watchdog to recover from lost TCOMP interrupts

[Théo Lebrun]

On Thu May 28, 2026 at 6:08 PM CEST, Andrea della Porta wrote:
> Has this patch seen a V3 version? I guess the only thing it's needed
> is something like this:
>
> static void macb_tx_timeout(struct net_device *dev, unsigned int txqueue)
> {
>         struct macb *bp = netdev_priv(dev);
>         macb_tx_restart(&bp->queues[txqueue]);
> }
>
> and then setting .ndo_tx_timeout = macb_tx_timeout in macb_netdev_ops.

Agreed! (pointed out here, with more details)
https://lore.kernel.org/netdev/DIK002QFFNBY.31C3KUX2SQC6W@xxxxxxxxxxx/

s/txqueue/q/ to respect the driver's traditions.

Sadly at91ether_netdev_ops cannot have macb_tx_timeout because code is
too different.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com