Re: [PATCH v3] net: fec: fix pinctrl default state restore order on resume

[Tapio Reijonen]

Hi Wei,

On 5/29/26 11:37, Wei Fang wrote:
> >   drivers/net/ethernet/freescale/fec_main.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c
> > b/drivers/net/ethernet/freescale/fec_main.c
> > index
> > f89aa94ce0202d5f28f37362ce70e0943aa14025..6ebde65d7f1b8728a6c5d28f7
> > 5cc0b0c4d983969 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -5594,6 +5594,7 @@ static int fec_resume(struct device *dev)
> >   		if (fep->rpm_active)
> >   			pm_runtime_force_resume(dev);
> >
> > +		pinctrl_pm_select_default_state(&fep->pdev->dev);
> >   		ret = fec_enet_clk_enable(ndev, true);
> >   		if (ret) {
> >   			rtnl_unlock();
> > @@ -5610,8 +5611,6 @@ static int fec_resume(struct device *dev)
> >   			val &= ~(FEC_ECR_MAGICEN | FEC_ECR_SLEEP);
> >   			writel(val, fep->hwp + FEC_ECNTRL);
> >   			fep->wol_flag &= ~FEC_WOL_FLAG_SLEEP_ON;
> > -		} else {
> > -			pinctrl_pm_select_default_state(&fep->pdev->dev);
> >   		}
> >   		fec_restart(ndev);
> >   		netif_tx_lock_bh(ndev);
>
> It looks good to me, thanks for fixing this issue.
>
> Reviewed-by: Wei Fang <wei.fang@xxxxxxx>
>
> By the way, it seems you posted two identical patches, which might
> cause confusion.
Yes, that was my mistake -- sorry for the noise.
I aborted the first 'b4 sned' with Ctrl-C, but it looks like the message 
had already been handed off to the SMTP server by that point, so it went 
out anyway.
I'll be more careful next time.

Thanks for the review!

Best regards,
Tapio Reijonen