Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX20860A

[Nuno Sá]

On Thu, May 28, 2026 at 06:41:31PM +0100, Conor Dooley wrote:
> On Thu, May 28, 2026 at 05:34:36PM +0000, Pradhan, Sanman wrote:
> > From: Sanman Pradhan <psanman@xxxxxxxxxxx>
> > 
> > Add devicetree binding documentation for the Analog Devices MAX20860A
> > step-down DC-DC switching regulator with PMBus interface.
> > 
> > Both "adi,max20860a" and "maxim,max20860a" compatible strings are
> > supported. The MAX20860A was originally manufactured by Maxim Integrated,
> > now part of Analog Devices.
> > 
> > Signed-off-by: Sanman Pradhan <psanman@xxxxxxxxxxx>
> > ---
> > v2:
> >   - Added allOf regulator.yaml reference and unevaluatedProperties
> 
> >   - Added "maxim,max20860a" as alternative compatible
> 
> No, please delete this.
> I don't remember what the policy that ADI use for things that used to be
> maxim products, but just pick one compatible for this device. I have a
> feeling they want adi to always be used in these cases.

Yes, adi should be the prefix.

- Nuno Sá

> 
> pw-bot: changes-requested
> 
> > 
> >  .../bindings/hwmon/pmbus/adi,max20860a.yaml   | 47 ++++++++++++++++++++
> >  1 file changed, 47 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > new file mode 100644
> > index 000000000000..f7eeb30f11b3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20860a.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,max20860a.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices MAX20860A Step-Down Converter
> > +
> > +maintainers:
> > +  - Sanman Pradhan <psanman@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The MAX20860A is a fully integrated step-down DC-DC switching regulator
> > +  with PMBus interface for monitoring input/output voltage, output current
> > +  and temperature.
> > +
> > +  Datasheet: https://www.analog.com/en/products/max20860a.html
> > +
> > +allOf:
> > +  - $ref: /schemas/regulator/regulator.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max20860a
> > +      - maxim,max20860a
> 
> And for future reference, please use fallback compatibles when dealing
> with devices that have the same programming mode.
> 
> Cheers,
> Conor.