RE: [PATCH 2/2] arm64: dts: renesas: r9a08g046l48-smarc: Enable rsci{1,2,3} nodes

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 29 May 2026 10:54
> Subject: Re: [PATCH 2/2] arm64: dts: renesas: r9a08g046l48-smarc: Enable rsci{1,2,3} nodes
> 
> Hi Biju,
> 
> On Tue, 19 May 2026 at 12:00, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Enable rsci{1,2,3} device nodes for the RZ/G3L SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dts
> 
> > @@ -147,6 +175,37 @@ ssi0_pins: ssi0 {
> >         };
> >  };
> >
> > +#if SW_SER0_PMOD
> > +&rsci1 {
> > +       pinctrl-0 = <&rsci1_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       uart-has-rtscts;
> > +
> > +       status = "okay";
> > +};
> > +#endif
> > +
> > +#if (!SW_DPI_EN) && (SW_SER0_PMOD)
> 
> Can 't you drop the last part?
>   - If SW_SER0_PMOD is enabled, rsci2 is routed to the PMOD connector,
>   - If SW_SER0_PMOD is disabled, rsci2 is routed to the M.2 connector
>     (replacing rsci1 above)
> In both cases it is available for use.


Yes, you are correct, that macro SW_SER0_PMOD check is not needed for
rsci2. I need to fix this for RZ/G3E as well.

Cheers,
Biju

> 
> > +&rsci2 {
> > +       pinctrl-0 = <&rsci2_pins>;
> > +       pinctrl-names = "default";
> > +
> > +       uart-has-rtscts;
> > +
> > +       status = "okay";
> > +};
> > +#endif
> 
> The rest LGTM.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds