RE: [PATCH 1/2] arm64: dts: renesas: r9a08g046: Add RSPI{0..2} nodes

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 29 May 2026 11:26
> Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a08g046: Add RSPI{0..2} nodes
> 
> Hi Biju,
> 
> On Tue, 19 May 2026 at 13:20, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Add device tree nodes for the three RSPI channels on the RZ/G3L
> > (R9A08G046) SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> I spoke too soon...
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a08g046.dtsi
> > @@ -442,6 +442,78 @@ rsci3: serial@100f3000 {
> >                         status = "disabled";
> >                 };
> >
> > +               rspi0: spi@100b0000 {
> > +                       compatible = "renesas,r9a08g046-rspi";
> > +                       reg = <0 0x100b0000 0 0x400>;
> > +                       interrupts = <GIC_SPI 440 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 441 IRQ_TYPE_LEVEL_HIGH>,
> > +                                    <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
> > +                                    <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>;
> > +                       interrupt-names = "idle", "error", "end", "rx", "tx";
> > +                       clocks = <&cpg CPG_MOD R9A08G046_RSPI0_PCLK>,
> > +                                <&cpg CPG_MOD R9A08G046_RSPI0_TCLK>;
> > +                       clock-names = "pclk", "tclk";
> > +                       resets = <&cpg R9A08G046_RSPI0_PRESETN>,
> > +                                <&cpg R9A08G046_RSPI0_TRESETN>;
> > +                       reset-names = "presetn", "tresetn";
> > +                       dmas = <&dmac 0x26f2>, <&dmac 0x26f1>;
> > +                       dma-names = "rx", "tx";
> > +                       power-domains = <&cpg>;
> > +                       num-cs = <1>;
> 
> Why specify this, and why one?
> The hardware has four, and the driver hardcodes four.

OK will drop this. Looks like I have copied this accidentally from
RZ/G2L.

Cheers,
Biju

> 
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +                       status = "disabled";
> > +               };
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds