Re: [PATCH] arm64: dts: renesas: Simplify AA1024XD12 display DTO

[Geert Uytterhoeven]

Hi Marek,

On Mon, 4 May 2026 at 16:38, Marek Vasut
<marek.vasut+renesas@xxxxxxxxxxx> wrote:
> Simplify the AA1024XD12 display DTO, move all the differences into the
> panel-aa104xd12.dtsi , rename OF_GRAPH links to generic lvds_panel_out
> and lvds_panel_in names, and parametrize the LVDS output in use using
> RENESAS_LVDS_OUTPUT macro. No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dtso
> +++ b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dtso
> @@ -6,36 +6,5 @@
>   * Copyright 2021 Ideas on Board Oy
>   */
>
> -/dts-v1/;
> -/plugin/;
> -
> -&{/} {
> +#define RENESAS_LVDS_OUTPUT    lvds1

Both Draak and Ebisu actually have two sets of LVDS and backlight
connectors, so you could connect such a panel to lvds0, too.

> --- a/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi
> +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi
> @@ -5,26 +5,52 @@

> +&{/} {
> +       panel {
> +               compatible = "mitsubishi,aa104xd12", "panel-lvds";
> +               backlight = <&backlight>;
> +
> +               width-mm = <210>;
> +               height-mm = <158>;
> +               data-mapping = "jeida-18";
> +
> +               panel-timing {
> +                       /* 1024x768 @65Hz */
> +                       clock-frequency = <65000000>;
> +                       hactive = <1024>;
> +                       vactive = <768>;
> +                       hsync-len = <136>;
> +                       hfront-porch = <20>;
> +                       hback-porch = <160>;
> +                       vfront-porch = <3>;
> +                       vback-porch = <29>;
> +                       vsync-len = <6>;
> +               };
> +
> +               port {
> +                       lvds_panel_in: endpoint {
> +                               remote-endpoint = <&lvds_panel_out>;
> +                       };
> +               };
>         };
> +};

With two panels, the channel-independent "lvds_panel_in" and
"lvds_panel_out" labels may become an issue.  I think you can
fix that later using C preprocessor concatenation?

As we don't support the dual-display use case yet anyway:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v7.2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds