Re: [PATCH RFC v2 5/7] iio: osf: add UART serdev transport

[Kim Jinseob]

On Thu, May 28, 2026 at 11:06:00PM +0100, Jonathan Cameron wrote:

> Various things inline.

Addressed in RFC v3.

> Why is help text talking about a patch?

Addressed in RFC v3. I updated the Kconfig help text so it describes the
driver rather than the patch split.

> You zero them memory before passing to this.  That seems like a sensible
> pattern in which case this memset is unneeded.

Addressed in RFC v3. The unnecessary memset in osf_core_init() was removed.

> If these can happen add a comment on why. If not remove them as overly cautious
> checking.

Addressed in RFC v3. I removed the internal-only NULL checks in the core
receive path while keeping the protocol and stream boundary checks.

> Perhaps check ret in each of these and return early if set. Then we only
> do the shared path below on success.

Addressed in RFC v3. The receive path now uses a simpler early-return style.

> Given there is nothing else to do on error, return -EOPNOTSUPP; perhaps.

Addressed in RFC v3.

> Given these don't match up with things in probe() please add some comments
> to explain what they are undoing.

Addressed in RFC v3. I added a short remove-path ordering comment before the
serdev close/reset/unregister sequence.

Thanks

Jinseob