Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: add support for credit based shaper

[Andrew Lunn]

> > That's not the same logic.
> > If one of the two function pointer is NULL, the other can still be executed
> > (Maybe not that likely as that's probably a mistake in the driver)
> 
> True, but agree also that it shouldn’t happen (would be a driver bug).

However, a kernel splat because you have jumped through a NULL pointer
makes a good bug report. It is much more obvious what is wrong than a
report that somebody tried to configure TC, but nothing appeared to
happen.

	Andrew