Re: [PATCH v5 3/7] firmware: samsung: acpm: Fix dummy stubs to return ERR_PTR

[Arnd Bergmann]

On Fri, May 29, 2026, at 14:37, Tudor Ambarus wrote:
> On 5/29/26 3:09 PM, Krzysztof Kozlowski wrote:
>> On 29/05/2026 13:51, Arnd Bergmann wrote:
>
> I confirm that the ACPM protocol is mandatory for the clients to
> work, thanks!
>
>>> the option space without losing any build coverage.
>
> nice, I didn't know this. I guess it's a "greedy" algorithm in
> allmodconfig, if the dependency is met the dependents are enabled too.

It's not even that interesting I think: the way I understand it,
the values (=m for allmodconfig, random for randconfig) are
assigned first and then adjusted if dependencies are not
met. This means with my change, anything that would have
CONFIG_EXYNOS_ACPM_PROTOCOL=n and CONFIG_EXYNOS_ACPM_CLK=m now
turns off EXYNOS_ACPM_CLK as well, rather than turning on
CONFIG_EXYNOS_ACPM_PROTOCOL, but this still covers all
the combinations we need to test.

>> Sure, I am fine with it. I'll take your patch with a bit adjusted commit
>> msg.
>> 
>
> Thank you! I need to drop the devm_acpm_get_by_phandle dummy stub from:
> https://lore.kernel.org/linux-samsung-soc/a59c6e3a-6092-4114-8961-c2a71a812959@xxxxxxxxxx/T/#m0ac077507129c37b84443513eecadd70b5eaf8b8
>
> Shall I send again the entire set?

I'll just send my change on top of your 8ad2c29d53e6 ("firmware:
samsung: acpm: Add devm_acpm_get_by_phandle helper"). Since there
is no way to hit the actual bug on a running kernel, it can wait for
the merge window, and that way we don't need a rebase.

     Arnd