Re: [PATCH] firmware: samsung: acpm: remove compile-testing stubs
From: Krzysztof Kozlowski
Date: Fri May 29 2026 - 10:16:21 EST
On Fri, 29 May 2026 15:43:31 +0200, Arnd Bergmann wrote:
> Sashiko reported an inconsistent use of NULL vs ERR_PTR()
> returns in the stub helpers in xynos-acpm-protocol.h.
>
> Since this only happens on dead code for COMPILE_TEST=y, this is not
> really a bug though. Having stub functions that return NULL is a common
> way to define optional interfaces, where callers still work when the
> feature is disabled, though this clearly does not work for acpm because
> some callers have a NULL pointer dereference when compile testing.
>
> [...]
Applied, thanks!
[1/1] firmware: samsung: acpm: remove compile-testing stubs
https://git.kernel.org/krzk/linux/c/7b661285aa7507eab79efff0a418445157db4141
Best regards,
--
Krzysztof Kozlowski <krzk@xxxxxxxxxx>