Re: [PATCH v1 3/6] power: supply: max17042: Drop driver data in of and platform device id arrays

[Uwe Kleine-König (The Capable Hub)]

On Fri, May 29, 2026 at 12:18:18PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> These values are not used, the relevant distinction happens in the mfd
> parent driver. So they can be dropped.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
> ---
>  drivers/power/supply/max17042_battery.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index 167fb3fb3732..3c50f5ba0591 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -1298,7 +1298,7 @@ static SIMPLE_DEV_PM_OPS(max17042_pm_ops, max17042_suspend,
>  
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id max17042_acpi_match[] = {
> -	{ "MAX17047", MAXIM_DEVICE_TYPE_MAX17047 },
> +	{ "MAX17047" },

This part is wrong. I missed that max17042_acpi_match is also used for
the i2c driver where the data is queried. Thanks to sashiko[1] for
noticing.

So please don't apply this patch.

As of now I assume the other patches are fine. I will check which parts
of the series didn't make it into next and/or the mainline later,
probably around the next merge window and resend accordingly.

Thanks
Uwe

[1] https://sashiko.dev/#/patchset/cover.1780048925.git.u.kleine-koenig%40baylibre.com

Attachment: signature.asc
Description: PGP signature