Re: [PATCH v2 1/4] arm64: dts: ti: k3-am67a-beagley-ai: Add I2C2 pinctrl

[Nishanth Menon]

On 06:46-20260515, Jai Luthra wrote:
> I2C2 is used by camera sensor devices connected on the 22-pin CSI0
> connector. Add the pin definition here so I2C2 may be enabled by the
> camera sensor overlays.
> 

Why not add the i2c node here with the pinmux, but disable the node with a
comment that this should be enabled for camera sensors? A bit confused
seeing a orphan pinmux node. but i dont see any other function for the
i2c2 other than support the camera sensors :)


> Signed-off-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> index 5255e04b9ac7..06aac02a7668 100644
> --- a/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dts
> @@ -157,6 +157,13 @@ J722S_IOPAD(0x01e4, PIN_INPUT_PULLUP, 0) /* (B22) I2C0_SDA */
>  		bootph-all;
>  	};
>  
> +	main_i2c2_pins_default: main-i2c2-default-pins {
> +		pinctrl-single,pins = <
> +			J722S_IOPAD(0x00b0, PIN_INPUT_PULLUP, 1) /* (P22) GPMC0_CSn2.I2C2_SCL */
> +			J722S_IOPAD(0x00b4, PIN_INPUT_PULLUP, 1) /* (P23) GPMC0_CSn3.I2C2_SDA */
> +		>;
> +	};
> +
>  	main_uart0_pins_default: main-uart0-default-pins {
>  		pinctrl-single,pins = <
>  			J722S_IOPAD(0x01c8, PIN_INPUT, 0)	/* (A22) UART0_RXD */
> 
> -- 
> 2.54.0
> 
> 


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource