Re: [PATCH v3 0/4] s390: Enable Rust support and add required arch glue

[Jan Polensky]

On Thu, May 28, 2026 at 03:14:29PM +0100, Gary Guo wrote:
> On Thu May 28, 2026 at 3:03 PM BST, Jan Polensky wrote:
> > On Wed, May 27, 2026 at 12:08:38PM +0200, Miguel Ojeda wrote:
> >> On Tue, May 26, 2026 at 6:13 PM Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
> >> >
> >> > An Ack from you would be appreciated, even though you made it already
> >> > clear that this series looks ok.
> >>
> > [snip]
> >> similarly named function `memcmp` defined here
> >>         |
> >>
> >> So we likely want a Rust helper here in `rust/helpers/`.
> >>
> >> Up to you which configs you want to support initially and how clean
> >> you want everything to be, of course, so:
> >>
> >> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> >>
> >> I hope this helps!
> >>
> >> Cheers,
> >> Miguel
> > Hi Miguel,
> >
> > thanks a lot for testing and for the Ack.
> >
> > The backchain warning is known. The KASAN report around the 1/2-byte
> > xchg emulation and the missing memchr in some configurations look like
> > separate follow-up patches rather than issues in this series, and I
> > plan to address them separately.
> >
> > Best regards,
> > Jan
>
> The memchr problem is something that need to be addressed in the series, because
> by introducing s390 into a mix you're turning a function that was previously
> always externed to something that cna be `static inline` and need helpers.
>
> KASAN fix can go separately.
>
> Best,
> Gary
Hi Gary,

thanks, I'll include the memchr-related changes and some more in v4.

Best regards,
Jan
``