Re: [PATCH v3 06/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI

[Nishanth Menon]

On 18:02-20260529, Francesco Dolcini wrote:
> On Fri, May 29, 2026 at 10:53:45AM -0500, Nishanth Menon wrote:
> > On 17:11-20260522, Vitor Soares wrote:
> > > +	touchscreen@41 {
> > > +		compatible = "ilitek,ili2132";
> > > +		reg = <0x41>;
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&pinctrl_dsi1_int>, <&pinctrl_i2s_2_bclk_gpio>;
> > > +		/* Verdin GPIO_9_DSI (SODIMM 17) - TOUCH_INT# */
> > > +		interrupt-parent = <&main_gpio1>;
> > > +		interrupts = <49 IRQ_TYPE_EDGE_RISING>;
> > 
> > https://lore.kernel.org/r/20260521152550.A928B1F000E9@xxxxxxxxxxxxxxx
> > https://lore.kernel.org/r/20260522140245.472651F000E9@xxxxxxxxxxxxxxx
> > Sashiko comment would probably be good to explain - I see the same in
> > v3.
> 
> The interrupt pin of the ilitek,ili2132 touch controller is a very short
> pulse, the net name TOUCH_INT# is on the board side and it is generic,
> not specific on the touch controller used.
> 
> Both falling and edge would work fine.
> 
> The reason for using rising is that for the way the HW is designed the
> interrupt signal is not that "clean", and triggering on the falling edge
> produce some spurious interrupt. Those spurious interrupts are handled
> nicely by the driver, but they pollute the kernel logs for no reason.
> 
> 
> Nishanth: in general do you want an explicit answer to every comment made my
> sashiko?

Would be nice - or a comment in the code.. had me curious as well, when
i saw one dtso do it one way and the other do it the other way.. kinda
peaked interest.. ;)


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource