Re: [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay

From: Nihal Kumar Gupta

Date: Fri May 29 2026 - 13:43:05 EST




On 29-05-2026 03:58, bod@xxxxxxxxxx wrote:
> If the overlay is not specific to board then the overlay should have some
> kind of base name shikra-evk-imx577-camera.dtb
>
> This seems like a minor nit-pick and, it is 🙂
Thanks for the review!

The overlay is named after CQM because it's shared between CQM and CQS
both use PM4125 PMIC with identical camera supply rails. The only
difference between them is the integrated modem on CQM, which does not
affect camera hardware at all.

IQS uses PM8150 with different supply rails, so it needs its own overlay
and can't share with CQM/CQS. A generic shikra-evk-imx577-camera name
would be misleading since IQS is not compatible with this overlay.

Happy to rename to shikra-cqm-cqs-evk-imx577-camera if that makes the
shared scope clearer - open to suggestions.

------
Regards,
Nihal