Re: [GIT PULL] RTLA changes for 7.2

[Tomas Glozar]

pá 29. 5. 2026 v 15:57 odesílatel Steven Rostedt <rostedt@xxxxxxxxxxx> napsal:
>
> On Fri, 29 May 2026 15:06:43 +0200
> Tomas Glozar <tglozar@xxxxxxxxxx> wrote:
>
> > - Fix discrepancy in --dump-tasks option
> >
> > Due to a mistake, rtla-timerlat-hist used the CLI syntax "--dump-task"
> > instead of the documented "--dump-tasks". Change the option to match
> > both documentation and the other timerlat tool, rtla-timerlat-top.
>
> Is there any concern that scripts might be using the old option?

Good point, I'm not aware of any, but it is possible.

>
> I wonder if you should keep the old option for backward compatibility,
> but do not document that it exists.
>

I did not originally plan on keeping the old option - and the commit
does not keep it - but since libsubcmd allows match on prefixes in
general, it actually works in the tag:

$ ./rtla timerlat hist --help --dump-tasks

Usage: rtla timerlat hist [<options>] [-h|--help]
       --dump-tasks      prints the task running on all CPUs if stop
conditions are met (depends on !--no-aa)

$ sudo ./rtla timerlat hist -c 0 -T 1 --dump-task
# RTLA timerlat histogram
# Time unit is microseconds (us)
# Duration:   0 00:00:01
...
Printing CPU tasks:
   [000]              timerlatu/0:66862
   [001]                         :0
   [002]                         :0
   [003]                         :0
   [004]                         :0
   [005]                         :0
   [006]                   auditd:1000
   [007]                         :0
   [008]                         :0
   [009]                         :0
   [010]                         :0
   [011]                         :0
   [012]                         :0
   [013]                         :0

The only build where it does not work would be in the middle of the
pull request, with the --dump-tasks fix but without the libsubcmd
migration patchset.

Anyway, thanks for the feedback.

Tomas