RE: [PATCH net-next v3 05/14] net: ethernet: oa_tc6: Move OA TC6 MMS definitions to header file
From: Selvamani Rajagopal
Date: Fri May 29 2026 - 19:48:43 EST
> Subject: Re: [PATCH net-next v3 05/14] net: ethernet: oa_tc6: Move OA TC6 MMS
> definitions to header file
>
>
> This Message Is From an External Sender
> This message came from outside your organization.
>
> On Fri, May 29, 2026 at 06:39:52PM +0000, Selvamani Rajagopal wrote:
> > To prepare for other files to share the constant definitions for
> > clause 45 registers memory map selectors, moving to header file.
> > The values are from table 6 in OPEN Alliance specification.
>
> Please don't move them in one patch, and then move them again in the
> next.
Andrew,
I thought it would be clearer.
4/14 patch would just move the contents as it is, without any change to oa_tc6_std_def.h first.
Then 5/15 would move MMS definition to another header file.
As opposed, a method where part of definitions (MMS) would move to oa_tc6.h and rest would
go to oa_tc6_std_def.h in a single patch.
I understand what you are saying. I can move the #defines to two different files in a single patch.
>
> Andrew