[PATCHv2] ata: ahci_tegra: remove devm_kcalloc()
From: Rosen Penev
Date: Fri May 29 2026 - 20:42:51 EST
Combine allocations into one by using a flexible array member.
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
v2: Rebase
drivers/ata/ahci_tegra.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 554f05e09f98..142ba2ae1c83 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -176,8 +176,9 @@ struct tegra_ahci_priv {
/* Needs special handling, cannot use ahci_platform */
struct clk *sata_clk;
struct tegra_pmc *pmc;
- struct regulator_bulk_data *supplies;
const struct tegra_ahci_soc *soc;
+
+ struct regulator_bulk_data supplies[];
};
static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)
@@ -514,6 +515,7 @@ static const struct scsi_host_template ahci_platform_sht = {
static int tegra_ahci_probe(struct platform_device *pdev)
{
+ const struct tegra_ahci_soc *soc;
struct ahci_host_priv *hpriv;
struct tegra_ahci_priv *tegra;
struct resource *res;
@@ -523,14 +525,15 @@ static int tegra_ahci_probe(struct platform_device *pdev)
if (IS_ERR(hpriv))
return PTR_ERR(hpriv);
- tegra = devm_kzalloc(&pdev->dev, sizeof(*tegra), GFP_KERNEL);
+ soc = of_device_get_match_data(&pdev->dev);
+ tegra = devm_kzalloc(&pdev->dev, struct_size(tegra, supplies, soc->num_supplies), GFP_KERNEL);
if (!tegra)
return -ENOMEM;
hpriv->plat_data = tegra;
tegra->pdev = pdev;
- tegra->soc = of_device_get_match_data(&pdev->dev);
+ tegra->soc = soc;
tegra->sata_regs = devm_platform_ioremap_resource(pdev, 1);
if (IS_ERR(tegra->sata_regs))
@@ -578,12 +581,6 @@ static int tegra_ahci_probe(struct platform_device *pdev)
return dev_err_probe(&pdev->dev, PTR_ERR(tegra->pmc),
"failed to get PMC\n");
- tegra->supplies = devm_kcalloc(&pdev->dev,
- tegra->soc->num_supplies,
- sizeof(*tegra->supplies), GFP_KERNEL);
- if (!tegra->supplies)
- return -ENOMEM;
-
regulator_bulk_set_supply_names(tegra->supplies,
tegra->soc->supply_names,
tegra->soc->num_supplies);
--
2.54.0