Re: [PATCH v3 15/40] KVM: x86: Move the bulk of register specific code from x86.c to regs.c

[Yosry Ahmed]

On Fri, May 29, 2026 at 03:21:58PM -0700, Sean Christopherson wrote:
> Introduce regs.c, and move the vast majority of register specific code out
> of x86.c and into regs.c.  Deliberately leave behind MSR code (except for
> EFER, which can hardly be called an MSR), as KVM's MSR support is complex
> enough to warrant its own compilation unit, and doesn't have much in common
> with the other register code.
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

This is not just code movement. You're also renaming and introducing new
helpers in the process, making the patch not so easy to review.

A wise mine once told me not to do this:
https://lore.kernel.org/kvm/aYU87QeMg8_kTM-G@xxxxxxxxxx/

I have been waiting a few months for this, so here goes:

Stop. Bundling. Things. Together.