Re: [PATCH] MIPS: ath79: pci: remove

[Rosen Penev]

On Fri, May 29, 2026 at 5:09 AM Thomas Bogendoerfer
<tsbogend@xxxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 27, 2026 at 08:59:43PM -0700, Rosen Penev wrote:
> > Commit 85b9686dae30 ("MIPS: ath79: drop platform device registration code")
>
> this commit doesn't do anything with pci at all. Do you mean
> commit 73d8e6aa7d20 ("MIPS: ath79: drop legacy pci code") ?
Yes
>
> > removed the ability for anything to bind to these drivers and use them.
> > Meaning as is, these drivers cannot be used.
> >
> > Downstream OpenWrt has hack patches that add the missing OF stuff but
> > those are not suitable for upstream.
> >
> > The current plan is to rewrite these drivers using newer APIs and have
> > them live under drivers/pci/controller. But as for these, axe them.
>
> wouldn't it make more sense to revert the commit above and remove it
> after the change to a new pci implementation is really done ?
Why revert then remove? Even if that commit was reverted it's still
unusable. ath79 is OF only now.
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]