Re: [PATCH v2] dt-bindings: usb: convert PXA USB bindings to YAML

[Krzysztof Kozlowski]

On 30/05/2026 04:29, Jeremiah Bishop wrote:
> Convert the legacy pxa-usb.txt binding documentation to YAML schemas.

DT schema. Not YAML. There is no such thing as YAML schemas. See also
submitting patches. Same for subject.

> 
> The original text binding documented two distinct devices: the PXA OHCI
> USB host controller and the PXA270 USB device controller. Split the
> documentation into separate schemas, marvell,pxa-ohci.yaml and
> marvell,pxa270-udc.yaml, and remove the obsolete text binding.
> 
> The schemas preserve the existing compatible strings and properties used
> by current in-tree users while adding machine-readable validation and
> examples.

Drop, redundant. Say if you changed the binding.

> 
> Signed-off-by: Jeremiah Bishop <jbishop.dev@xxxxxxxxx>
> ---
> Changes in v2:
> - Add vbus1-supply, vbus2-supply, and vbus3-supply properties to the
>   PXA OHCI schema.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

> 
>  .../bindings/usb/marvell,pxa-ohci.yaml        | 100 ++++++++++++++++++
>  .../bindings/usb/marvell,pxa270-udc.yaml      |  50 +++++++++
>  .../devicetree/bindings/usb/pxa-usb.txt       |  53 ----------
>  3 files changed, 150 insertions(+), 53 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
>  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml
>  delete mode 100644 Documentation/devicetree/bindings/usb/pxa-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
> new file mode 100644
> index 000000000000..5d660b92d3cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/marvell,pxa-ohci.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/marvell,pxa-ohci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA OHCI USB Host Controller
> +
> +maintainers:
> +  - Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> +  - Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

No, subsystem maintainers are not maintainers of this binding. This
could be platform maintainer.

> +
> +allOf:
> +  - $ref: usb-hcd.yaml#
> +
> +properties:
> +  compatible:
> +    const: marvell,pxa-ohci
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  marvell,enable-port1:
> +    type: boolean
> +    description: Enable USB port 1 if present.
> +
> +  marvell,enable-port2:
> +    type: boolean
> +    description: Enable USB port 2 if present.
> +
> +  marvell,enable-port3:
> +    type: boolean
> +    description: Enable USB port 3 if present.> +
> +  marvell,port-sense-low:
> +    type: boolean
> +    description: Port sense pin in low-active.
> +
> +  marvell,power-control-low:
> +    type: boolean
> +    description: Power control pin is low-active.
> +
> +  marvell,no-oc-protection:
> +    type: boolean
> +    description: Disable over-current protection.
> +
> +  marvell,oc-mode-perport:
> +    type: boolean
> +    description: Enable per-port over-current protection.
> +
> +  marvell,power-on-delay:

power_on_delay? Your commit msg must clearly list the changes done to
the binding during conversion with explanation why.


> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Power On to Power Good time in milliseconds.
> +
> +  marvell,port-mode:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [1, 2, 3]
> +    description: |
> +      Selects the mode of the ports.
> +        1 = PMM_NPS_MODE
> +        2 = PMM_GLOBAL_MODE
> +        3 = PMM_PERPORT_MODE
> +
> +  marvell,power-budget:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: USB power budget.

There was no such property.

> +
> +  vbus1-supply:
> +    description: Regulator supplying VBUS for port 1.
> +
> +  vbus2-supply:
> +    description: Regulator supplying VBUS for port 2.
> +
> +  vbus3-supply:
> +    description: Regulator supplying VBUS for port 3.

Neither these.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks

There were no interrupts or clocks.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    usb@4c000000 {
> +        compatible = "marvell,pxa-ohci";
> +        reg = <0x4c000000 0x100000>;
> +        interrupts = <3>;
> +        clocks = <&clks 11>;
> +        marvell,enable-port1;
> +        marvell,port-mode = <2>; /* PMM_GLOBAL_MODE */
> +    };
> diff --git a/Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml b/Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml
> new file mode 100644
> index 000000000000..0be51e0db80b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/marvell,pxa270-udc.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/marvell,pxa270-udc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA27x USB Device Controller (UDC)
> +
> +maintainers:
> +  - Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Same problem

> +
> +properties:
> +  compatible:
> +    const: marvell,pxa270-udc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  gpios:
> +    maxItems: 1
> +    description: GPIO to control the USB D+ pullup.
> +
> +  phys:
> +    maxItems: 1

There was no such property.


Best regards,
Krzysztof