Re: [PATCH v4] dt-bindings: clock: via,vt8500: Convert to DT Schema

[Krzysztof Kozlowski]

On Sun, May 24, 2026 at 08:40:26PM +0530, Udaya Kiran Challa wrote:
> Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
> controller binding from the legacy text format to DT schema.
> 
> Signed-off-by: Udaya Kiran Challa <challauday369@xxxxxxxxx>
> ---
> Changelog:
> Changes since v3
> - Add schema select matching for via,vt8500-pmc
> - Allow hyphen in node names under patternProperties
> - Add dependentRequired validation for enable-reg/enable-bit
> - Fix example validation against PMC schema
> 
> Link to v3:https://lore.kernel.org/all/20260524111813.39810-1-challauday369@xxxxxxxxx/
> 
> Changes since v2:
> - Drop redundant description for clocks
> - Disable reg property for device clocks
> - Fix schema hierarchy to match actual DTS structure
> 
> Link to v2:https://lore.kernel.org/all/20260521170810.19702-1-challauday369@xxxxxxxxx/
> 
> Changes since v1:
> - Add default value for divisor-mask
> - Add required properties compatible and model
> - Fix example node name
> - Update example size cells and reg value
> 
> Link to v1:https://lore.kernel.org/all/20260520025131.17772-1-challauday369@xxxxxxxxx/
> ---
>  .../bindings/clock/via,vt8500-clock.yaml      | 209 ++++++++++++++++++
>  .../devicetree/bindings/clock/vt8500.txt      |  74 -------
>  2 files changed, 209 insertions(+), 74 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
>  delete mode 100644 Documentation/devicetree/bindings/clock/vt8500.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> new file mode 100644
> index 000000000000..51a68df6c2f3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> @@ -0,0 +1,209 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/via,vt8500-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA/Wondermedia VT8500 Clock Controller

How PMC is a clock controller? Really?

> +
> +maintainers:
> +  - Michael Turquette <mturquette@xxxxxxxxxxxx>
> +  - Stephen Boyd <sboyd@xxxxxxxxxx>


Subsystem maintainers do not care about PMC. This can be platform
maintainer.

> +
> +description:
> +  Clock controller bindings for VIA/Wondermedia VT8500 and Wondermedia WM8xxx
> +  series SoCs.
> +
> +select:
> +  properties:
> +    compatible:
> +      const: via,vt8500-pmc
> +
> +  required:
> +    - compatible

Why do you have select?

I don't understand your changes. This was not at v2 and I did not ask to
change that.

> +
> +properties:
> +  compatible:
> +    const: via,vt8500-pmc


So via,vt8500-clock.yaml or pmc? Why aren't you removing the pmc file?
Why is this located at clocks?

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    type: object
> +    additionalProperties: true

No, this cannot be "true".

I finished review here.

Best regards,
Krzysztof