Re: [PATCH 2/3] dt-bindings: serial: maxim,max310x: allow per-port subnodes for rs485

[Krzysztof Kozlowski]

On Mon, May 25, 2026 at 09:43:38AM +0000, Tapio Reijonen wrote:
> The MAX310x is a multi-port UART (up to four ports). The existing
> binding pulls in /schemas/serial/rs485.yaml at the top level, which
> only describes a single port - sufficient for max3107 but ambiguous
> for max14830 where each port can have its own RS485 wiring.
> 
> Add a "port@N" pattern (N = 0..3) carrying rs485 properties on a
> per-port basis. When port@N subnodes are present, the chip node also
> needs #address-cells = <1> and #size-cells = <0>; allow both. Top-
> level rs485 properties remain accepted for compatibility.
> 
> Signed-off-by: Tapio Reijonen <tapio.reijonen@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/serial/maxim,max310x.yaml  | 60 ++++++++++++++++++++++
>  1 file changed, 60 insertions(+)

That's a total mess now in the binding.
1. maxim,max3107 does not have ports, but you add there. You need to
constrain (see writing bindings) or split.
2. So where do you place serial devices? Did you validate any of this?

Best regards,
Krzysztof