Re: [PATCH 1/4] dt-bindings: bluetooth: qcom,qcc2072-bt: add bindings for QCC2072
From: Krzysztof Kozlowski
Date: Sat May 30 2026 - 08:36:54 EST
On Fri, May 29, 2026 at 11:23:42PM +0530, Yepuri Siddu wrote:
> Document the YAML binding schema for the Qualcomm QCC2072 UART-based
> Bluetooth controller.
Where is the rest?
Also:
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Unlike other Qualcomm Bluetooth chips, QCC2072 requires no external
> voltage regulators. The schema inherits common Qualcomm Bluetooth
> properties via qcom,bluetooth-common.yaml and serial peripheral
> interface properties for the UART link.
>
> Signed-off-by: Yepuri Siddu <yepuri.siddu@xxxxxxxxxxxxxxxx>
> ---
> .../net/bluetooth/qcom,qcc2072-bt.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> new file mode 100644
> index 000000000000..8e2f15a75d62
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qcom,qcc2072-bt.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/qcom,qcc2072-bt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm QCC2072 Bluetooth
> +
> +maintainers:
> + - Balakrishna Godavarthi <quic_bgodavar@xxxxxxxxxxx>
> + - Rocky Liao <quic_rjliao@xxxxxxxxxxx>
> +
> +description:
> + Qualcomm QCC2072 is a UART-based Bluetooth controller.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,qcc2072-bt
> +
> +required:
> + - compatible
> +
Looks heavily incomplete. Devices do not work without power for example.
> +allOf:
> + - $ref: bluetooth-controller.yaml#
> + - $ref: qcom,bluetooth-common.yaml#
> + - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + serial {
> + bluetooth {
> + compatible = "qcom,qcc2072-bt";
> + max-speed = <3200000>;
Also incomplete.
Best regards,
Krzysztof