Re: [PATCH] tracing/probes: Point the error offset correctly for eprobe argument error
From: Google
Date: Sat May 30 2026 - 09:48:07 EST
On Thu, 28 May 2026 22:29:34 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Mon, 25 May 2026 11:21:14 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
>
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> >
> > Fix to point the error offset correctly for eprobe argument error.
> > In the cleanup commit 1b8b0cd754cd ("tracing/probes: Move event parameter
> > fetching code to common parser"), due to incorrect backward compatibility
> > aimed at conforming to the test specifications, the error location was set
> > to 0 when a non-existent formal parameter was specified for Eprobe.
> > However, this should be corrected in both the test and the implementation
> > to point correct error position.
> >
> > Fixes: 1b8b0cd754cd ("tracing/probes: Move event parameter fetching code to common parser")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
>
> Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
Thanks! Let me pick this to probes/fixes branch.
> -- Steve
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>