Re: [PATCH] crypto: crypto4xx - Remove insecure and unused rng_alg
From: Eric Biggers
Date: Sat May 30 2026 - 15:12:26 EST
On Sat, May 30, 2026 at 12:20:57PM +0200, Christian Lamparter wrote:
> > diff --git a/drivers/crypto/amcc/crypto4xx_reg_def.h b/drivers/crypto/amcc/crypto4xx_reg_def.h
> > index 1038061224da..73d626308a84 100644
> > --- a/drivers/crypto/amcc/crypto4xx_reg_def.h
> > +++ b/drivers/crypto/amcc/crypto4xx_reg_def.h
> > @@ -88,24 +88,13 @@
> > #define CRYPTO4XX_DMA_CFG 0x000600d4
> > #define CRYPTO4XX_BYTE_ORDER_CFG 0x000600d8
> > #define CRYPTO4XX_ENDIAN_CFG 0x000600d8
> > -#define CRYPTO4XX_PRNG_STAT 0x00070000
> > -#define CRYPTO4XX_PRNG_STAT_BUSY 0x1
> > #define CRYPTO4XX_PRNG_CTRL 0x00070004
> > #define CRYPTO4XX_PRNG_SEED_L 0x00070008
> > #define CRYPTO4XX_PRNG_SEED_H 0x0007000c
> > -
> > -#define CRYPTO4XX_PRNG_RES_0 0x00070020
> > -#define CRYPTO4XX_PRNG_RES_1 0x00070024
> > -#define CRYPTO4XX_PRNG_RES_2 0x00070028
> > -#define CRYPTO4XX_PRNG_RES_3 0x0007002C
> > -
> > -#define CRYPTO4XX_PRNG_LFSR_L 0x00070030
> > -#define CRYPTO4XX_PRNG_LFSR_H 0x00070034
> > -
>
> Hmm, don't think these defines will hurt anyone? As these are part of the hardware spec.
> Or do you forsee a future where AI-Agents will sent patches hallucinating that it "fixed"
> the issue which readds it? I have no idea.
Well, there's not really any point in keeping these when they aren't
used.
- Eric