Re: [PATCH v2 2/3] dt-bindings: iio: flow: add Sensirion SLF3S liquid flow sensor

From: Wadim Mueller

Date: Sat May 30 2026 - 16:44:00 EST


On Thu, May 28, 2026 at 11:07:18AM +0200, Krzysztof Kozlowski wrote:
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). [...]

Understood, v3 will be a new thread.

> No need for cc of maintainers here which are output by
> get_maintainers.pl. [...] Anyway, your SoB must be the last.

Ok, will drop the manual Cc block and put SoB last.

> > + - const: sensirion,slf3s
>
> That's confusing - why do you have generic compatible allowed to be
> alone?

The driver detects the sub-type anyway, so the generic-only form
does not add anything. Will drop it and keep only the fallback
pair.

> > + sensirion,medium:
>
> Sounds like you configure driver probe behavior. Why this is board-level
> static configuration (DT)?

Agreed, that is runtime config and not hardware description. Will
drop the property and expose it as a sysfs RW attribute instead.

> Please make example complete - add all properties.

Will do.

> > +F:drivers/iio/flow/
>
> Drop, you don't maintain that directory here.

Will drop, only the binding YAML and slf3s.c stay.

Thanks,
Wadim