Re: [PATCH v2] spi: cadence-xspi: Support 32bit and 64bit slave dma interface

[kernel test robot]

Hi Jisheng,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on linus/master v7.1-rc5 next-20260529]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/spi-cadence-xspi-Support-32bit-and-64bit-slave-dma-interface/20260530-205805
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20260530123715.25899-1-jszhang%40kernel.org
patch subject: [PATCH v2] spi: cadence-xspi: Support 32bit and 64bit slave dma interface
config: x86_64-randconfig-005-20260531 (https://download.01.org/0day-ci/archive/20260531/202605310818.A7laSi0h-lkp@xxxxxxxxx/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260531/202605310818.A7laSi0h-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605310818.A7laSi0h-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/spi/spi-cadence-xspi.c:601:4: error: call to undeclared function 'ioread64_rep'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     601 |                         ioread64_rep(src, buf, len >> 3);
         |                         ^
>> drivers/spi/spi-cadence-xspi.c:623:4: error: call to undeclared function 'iowrite64_rep'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     623 |                         iowrite64_rep(dst, buf, len >> 3);
         |                         ^
   2 errors generated.


vim +/ioread64_rep +601 drivers/spi/spi-cadence-xspi.c

   586	
   587	static inline void cdns_xspi_sdma_read(struct cdns_xspi_dev *cdns_xspi, size_t len)
   588	{
   589		void __iomem *src = cdns_xspi->sdmabase;
   590		void *buf = cdns_xspi->in_buffer;
   591		size_t offset = 0;
   592	
   593		if (cdns_xspi->dma_data_width == 4) {
   594			if (IS_ALIGNED((uintptr_t)src, 4) && IS_ALIGNED((uintptr_t)buf, 4)) {
   595				ioread32_rep(src, buf, len >> 2);
   596				offset = len & ~0x3;
   597				len -= offset;
   598			}
   599		} else {
   600			if (IS_ALIGNED((uintptr_t)src, 8) && IS_ALIGNED((uintptr_t)buf, 8)) {
 > 601				ioread64_rep(src, buf, len >> 3);
   602				offset = len & ~0x7;
   603				len -= offset;
   604			}
   605		}
   606		ioread8_rep(src, (u8 *)buf + offset, len);
   607	}
   608	
   609	static inline void cdns_xspi_sdma_write(struct cdns_xspi_dev *cdns_xspi, size_t len)
   610	{
   611		void __iomem *dst = cdns_xspi->sdmabase;
   612		const void *buf = cdns_xspi->out_buffer;
   613		size_t offset = 0;
   614	
   615		if (cdns_xspi->dma_data_width == 4) {
   616			if (IS_ALIGNED((uintptr_t)dst, 4) && IS_ALIGNED((uintptr_t)buf, 4)) {
   617				iowrite32_rep(dst, buf, len >> 2);
   618				offset = len & ~0x3;
   619				len -= offset;
   620			}
   621		} else {
   622			if (IS_ALIGNED((uintptr_t)dst, 8) && IS_ALIGNED((uintptr_t)buf, 8)) {
 > 623				iowrite64_rep(dst, buf, len >> 3);
   624				offset = len & ~0x7;
   625				len -= offset;
   626			}
   627		}
   628		iowrite8_rep(dst, (const u8 *)buf + offset, len);
   629	}
   630	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki