Re: [PATCH v3 2/2] iio: light: veml3328: add support for new device

[Jonathan Cameron]

On Sat, 30 May 2026 19:23:53 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Sat, 30 May 2026 at 19:07, Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> >
> > Add support for the Vishay VEML3328 RGB/IR light sensor communicating
> > via I2C (SMBus compatible).
> >
> > Also add a new entry for said driver into Kconfig and Makefile.
> >
> > Assisted-by: Gemini:3.1-Pro
> > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > ---  
> 
> Sashiko had a few remarks, two are bogus IMO, but it does mention
> that the device isn't put to sleep after probing...
> 
> https://sashiko.dev/#/patchset/20260530-veml3328-v3-0-dd562eaee8d9%40gmail.com
> 

I vaguely recall looking into this years ago and being convinced that it
would autosuspend. Easiest is probably to verify if it does by just testing
the device.

However that might rely on turning runtime pm on before calling use_autosuspend
whereas you have it in a different order here.

One of the other sashiko comments is correct.. I'll reply to the patch.