Re: [PATCH net] net: ibm: emac: Fix NULL pointer dereference in emac_probe

From: Andrew Lunn

Date: Sun May 31 2026 - 10:39:57 EST


On Sat, May 30, 2026 at 07:22:19PM -0700, Rosen Penev wrote:
> Move devm_request_irq() after devm_platform_ioremap_resource() so that
> dev->emacp is mapped before the interrupt handler can fire. An early
> interrupt hitting emac_irq() would dereference the NULL dev->emacp and
> crash.

Please add an explanation how this can happen, given that iser is
written in open() not probe().

> Fixes: dcc34ef7c834 ("net: ibm: emac: manage emac_irq with devm")

Is this actually bothering people?

Andrew