Re: [PATCH 5/5] selftests/damon: fix dead code, skipped checks, and broken lookups

[SeongJae Park]

On Sun, 31 May 2026 17:17:24 +0800 Kunwu Chan <kunwu.chan@xxxxxxxxx> wrote:

> From: Kunwu Chan <kunwu.chan@xxxxxxxxx>
> 
> 'hugeapge_size' in drgn_dump_damon_status.py was a dead elif branch.
> $fail_reason in sysfs.sh was undefined, silently emptying the error
> message.  'exit' instead of 'exist' in sysfs.sh skipped a file
> existence check.  'nohugeapge' in sysfs.py broke an action dict
> lookup.
> 
> Fix other wrong strings in the same files.

Good eyes!  Thank you for fixing these!

> 
> Co-developed-by: Wang Lian <lianux.mm@xxxxxxxxx>
> Signed-off-by: Wang Lian <lianux.mm@xxxxxxxxx>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>

Checkpatch.pl will warn as below, and it should be fixed.

WARNING: From:/Signed-off-by: email address mismatch: 'From: Kunwu Chan <kunwu.chan@xxxxxxxxx>' != 'Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>'

Other than that,

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]