Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled

[Daniel Lezcano]

On 5/31/26 19:49, Ronald Claveau wrote:
> On 5/31/26 10:41 AM, Daniel Lezcano wrote:
> > On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote:
> > > From: Ronald Claveau <linux-kernel-dev@xxxxxxxx>

[ ... ]

> > > +#if IS_ENABLED(CONFIG_MESON_SM)
> > > +
> > >    struct meson_sm_firmware *meson_sm_get(struct device_node
> > > *firmware_node);
> > >    int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32
> > > *trim_info,
> > >                       u32 tsensor_id);
> >
> > Do you really want to compile meson_sm as a module ?
>
> I don't want, but if I send a patch to change tristate to bool, it will
> raise a warning because 'm' is not valid.
> If it is accepted to ignore this warning, I can send another patch.


Sorry, I don't get your point :/

'm' is a config option, make menuconfig should set it to yes or not set.

Compiling the firmware as a module means it must be loaded before the 
amlogic thermal driver, right ? Where is the dependency declared in the 
module ?

If the sm_meson is in the platform, it should be selected as part of the 
platform's component. No need to have an option for that, no ?